lkml.org 
[lkml]   [2020]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/2] Arm: dts: aspeed-g6: Add sgpio node and pinctrl setting
On Mon, 12 Oct 2020 at 05:25, Billy Tsai <billy_tsai@aspeedtech.com> wrote:
>
> Hi Joel,
>
> On 2020/10/8, 11:49 AM, Joel Stanley wrote:
>
> On Thu, 8 Oct 2020 at 01:51, Billy Tsai <billy_tsai@aspeedtech.com> wrote:
> > >
> > > This patch is used to add sgpiom and sgpios nodes and add pinctrl setting
> > > for sgpiom1
> >
> > The code looks good Billy.
> >
> > Please split the change in two: device tree changes (arch/arm/dts) in
> > one, and pinctrl in the second, as they go through different
> > maintainers.
> >
>
> If I split the change in two, the patch of dts will have a compiler error.
> Because that the sgpiom1 node needs the pinctrl symbol "&pinctrl_sgpm2_default".

The drivers/pinctrl/ changes should be split from the
arch/arm/boot/dts/ changes.

You should keep the arch/arm/boot/dts/ changes in the same patch.

Cheers,

Joel

\
 
 \ /
  Last update: 2020-10-29 00:13    [W:0.059 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site