Messages in this thread Patch in this message | | | From | Zhiqiang Liu <> | Subject | [PATCH] pipe: fix potential inode leak in create_pipe_files() | Date | Wed, 28 Oct 2020 11:03:52 +0800 |
| |
In create_pipe_files(), if alloc_file_clone() fails, we will call put_pipe_info to release pipe, and call fput() to release f. However, we donot call iput() to free inode.
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com> Signed-off-by: Feilong Lin <linfeilong@huawei.com> --- fs/pipe.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/fs/pipe.c b/fs/pipe.c index 0ac197658a2d..8856607fde65 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -924,6 +924,7 @@ int create_pipe_files(struct file **res, int flags) if (IS_ERR(res[0])) { put_pipe_info(inode, inode->i_pipe); fput(f); + iput(inode); return PTR_ERR(res[0]); } res[0]->private_data = inode->i_pipe; -- 2.19.1
| |