Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 28 Oct 2020 22:25:32 +0200 | Subject | Re: [PATCH v2] gpio: mockup: Allow probing from device tree |
| |
On Wed, Oct 28, 2020 at 8:41 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > On Tue, Oct 27, 2020 at 2:54 PM Vincent Whitchurch > <vincent.whitchurch@axis.com> wrote:
...
> > +#include <linux/of.h> > > Please keep the includes ordered alphabetically.
Besides the fact that that is a wrong header to be included. mod_devicetable.h is the correct one. (See also below)
...
> > +#ifdef CONFIG_OF > > +static const struct of_device_id gpio_mockup_of_match[] = { > > + { .compatible = "gpio-mockup", }, > > + {}, > > +}; > > +MODULE_DEVICE_TABLE(of, gpio_mockup_of_match); > > +#endif > > You don't need this ifdef - of_match_ptr() will evaluate to NULL if > CONFIG_OF is disabled and the compiler will optimize this struct out.
It's not so. If you drop ugly ifdeffery (and I vote for that, see also above) the of_match_ptr() must be dropped as well. Otherwise the compiler will issue the warning. So it is either all or none.
-- With Best Regards, Andy Shevchenko
| |