Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH v2 1/3] genirq/affinity: Add irq_update_affinity_desc() | Date | Wed, 28 Oct 2020 19:22:29 +0100 |
| |
On Wed, Oct 28 2020 at 20:33, John Garry wrote: > > +int irq_update_affinity_desc(unsigned int irq, > + struct irq_affinity_desc *affinity) > +{ > + unsigned long flags; > + struct irq_desc *desc = irq_get_desc_lock(irq, &flags, 0); > + > + if (!desc) > + return -EINVAL;
Just looking at it some more. This needs a check whether the interrupt is actually shut down. Otherwise the update will corrupt state. Something like this:
if (irqd_is_started(&desc->irq_data)) return -EBUSY;
But all of this can't work on x86 due to the way how vector allocation works. Let me think about that.
Thanks,
tglx
| |