Messages in this thread Patch in this message | | | From | Zou Wei <> | Subject | [PATCH -next] net: nvidia: forcedeth: remove useless if/else | Date | Thu, 29 Oct 2020 10:30:14 +0800 |
| |
Fix the following coccinelle report:
./drivers/net/ethernet/nvidia/forcedeth.c:3479:8-10: WARNING: possible condition with no effect (if == else)
Both branches are the same, so remove the else if/else altogether.
Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> --- drivers/net/ethernet/nvidia/forcedeth.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c index 2fc10a3..87ed7e1 100644 --- a/drivers/net/ethernet/nvidia/forcedeth.c +++ b/drivers/net/ethernet/nvidia/forcedeth.c @@ -3476,9 +3476,6 @@ static int nv_update_linkspeed(struct net_device *dev) } else if (adv_lpa & LPA_10FULL) { newls = NVREG_LINKSPEED_FORCE|NVREG_LINKSPEED_10; newdup = 1; - } else if (adv_lpa & LPA_10HALF) { - newls = NVREG_LINKSPEED_FORCE|NVREG_LINKSPEED_10; - newdup = 0; } else { newls = NVREG_LINKSPEED_FORCE|NVREG_LINKSPEED_10; newdup = 0; -- 2.6.2
| |