Messages in this thread | | | Subject | Re: [f2fs-dev] [PATCH 1/1] f2fs-toos:fsck.f2fs Fix bad return value | From | Chao Yu <> | Date | Wed, 28 Oct 2020 14:57:56 +0800 |
| |
On 2020/10/26 17:40, Robin Hsu via Linux-f2fs-devel wrote: > 'ret' should not have been used here: otherwise, it would be wrongly used > as the error code and then be returned from main(). > > Signed-off-by: Robin Hsu <robinhsu@google.com>
BTW, how about changing 'ret = EXIT_ERR_CODE' to 'ret = FSCK_ERRORS_LEFT_UNCORRECTED', it's not critical though.
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
| |