lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 042/264] crypto: picoxcell - Fix potential race condition bug
    Date
    From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>

    [ Upstream commit 64f4a62e3b17f1e473f971127c2924cae42afc82 ]

    engine->stat_irq_thresh was initialized after device_create_file() in
    the probe function, the initialization may race with call to
    spacc_stat_irq_thresh_store() which updates engine->stat_irq_thresh,
    therefore initialize it before creating the file in probe function.

    Found by Linux Driver Verification project (linuxtesting.org).

    Fixes: ce92136843cb ("crypto: picoxcell - add support for the...")
    Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
    Acked-by: Jamie Iles <jamie@jamieiles.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/picoxcell_crypto.c | 9 ++++-----
    1 file changed, 4 insertions(+), 5 deletions(-)

    diff --git a/drivers/crypto/picoxcell_crypto.c b/drivers/crypto/picoxcell_crypto.c
    index e2491754c468f..1ef47f7208b92 100644
    --- a/drivers/crypto/picoxcell_crypto.c
    +++ b/drivers/crypto/picoxcell_crypto.c
    @@ -1701,11 +1701,6 @@ static int spacc_probe(struct platform_device *pdev)
    goto err_clk_put;
    }

    - ret = device_create_file(&pdev->dev, &dev_attr_stat_irq_thresh);
    - if (ret)
    - goto err_clk_disable;
    -
    -
    /*
    * Use an IRQ threshold of 50% as a default. This seems to be a
    * reasonable trade off of latency against throughput but can be
    @@ -1713,6 +1708,10 @@ static int spacc_probe(struct platform_device *pdev)
    */
    engine->stat_irq_thresh = (engine->fifo_sz / 2);

    + ret = device_create_file(&pdev->dev, &dev_attr_stat_irq_thresh);
    + if (ret)
    + goto err_clk_disable;
    +
    /*
    * Configure the interrupts. We only use the STAT_CNT interrupt as we
    * only submit a new packet for processing when we complete another in
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 15:21    [W:3.465 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site