lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 146/191] media: platform: sti: hva: Fix runtime PM imbalance on error
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    [ Upstream commit d912a1d9e9afe69c6066c1ceb6bfc09063074075 ]

    pm_runtime_get_sync() increments the runtime PM usage counter even
    when it returns an error code. Thus a pairing decrement is needed on
    the error handling path to keep the counter balanced.

    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/sti/hva/hva-hw.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/platform/sti/hva/hva-hw.c b/drivers/media/platform/sti/hva/hva-hw.c
    index 8dce2ccc551cb..1185f6b6721e9 100644
    --- a/drivers/media/platform/sti/hva/hva-hw.c
    +++ b/drivers/media/platform/sti/hva/hva-hw.c
    @@ -393,7 +393,7 @@ int hva_hw_probe(struct platform_device *pdev, struct hva_dev *hva)
    ret = pm_runtime_get_sync(dev);
    if (ret < 0) {
    dev_err(dev, "%s failed to set PM\n", HVA_PREFIX);
    - goto err_clk;
    + goto err_pm;
    }

    /* check IP hardware version */
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 15:19    [W:4.135 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site