lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 065/139] powerpc/tau: Remove duplicated set_thresholds() call
    Date
    From: Finn Thain <fthain@telegraphics.com.au>

    [ Upstream commit 420ab2bc7544d978a5d0762ee736412fe9c796ab ]

    The commentary at the call site seems to disagree with the code. The
    conditional prevents calling set_thresholds() via the exception handler,
    which appears to crash. Perhaps that's because it immediately triggers
    another TAU exception. Anyway, calling set_thresholds() from TAUupdate()
    is redundant because tau_timeout() does so.

    Fixes: 1da177e4c3f41 ("Linux-2.6.12-rc2")
    Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
    Tested-by: Stan Johnson <userm57@yahoo.com>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/d7c7ee33232cf72a6a6bbb6ef05838b2e2b113c0.1599260540.git.fthain@telegraphics.com.au
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/kernel/tau_6xx.c | 5 -----
    1 file changed, 5 deletions(-)

    diff --git a/arch/powerpc/kernel/tau_6xx.c b/arch/powerpc/kernel/tau_6xx.c
    index 1880481322880..f6a92bf5ebfc6 100644
    --- a/arch/powerpc/kernel/tau_6xx.c
    +++ b/arch/powerpc/kernel/tau_6xx.c
    @@ -107,11 +107,6 @@ void TAUupdate(int cpu)
    #ifdef DEBUG
    printk("grew = %d\n", tau[cpu].grew);
    #endif
    -
    -#ifndef CONFIG_TAU_INT /* tau_timeout will do this if not using interrupts */
    - set_thresholds(cpu);
    -#endif
    -
    }

    #ifdef CONFIG_TAU_INT
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 15:05    [W:4.068 / U:0.376 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site