lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 069/112] Input: ep93xx_keypad - fix handling of platform_get_irq() error
    Date
    From: Krzysztof Kozlowski <krzk@kernel.org>

    [ Upstream commit 7d50f6656dacf085a00beeedbc48b19a37d17881 ]

    platform_get_irq() returns -ERRNO on error. In such case comparison
    to 0 would pass the check.

    Fixes: 60214f058f44 ("Input: ep93xx_keypad - update driver to new core support")
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Link: https://lore.kernel.org/r/20200828145744.3636-1-krzk@kernel.org
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/input/keyboard/ep93xx_keypad.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c
    index f77b295e0123e..01788a78041b3 100644
    --- a/drivers/input/keyboard/ep93xx_keypad.c
    +++ b/drivers/input/keyboard/ep93xx_keypad.c
    @@ -257,8 +257,8 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
    }

    keypad->irq = platform_get_irq(pdev, 0);
    - if (!keypad->irq) {
    - err = -ENXIO;
    + if (keypad->irq < 0) {
    + err = keypad->irq;
    goto failed_free;
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 15:00    [W:4.082 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site