lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 048/112] mfd: sm501: Fix leaks in probe()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 8ce24f8967df2836b4557a23e74dc4bb098249f1 ]

    This code should clean up if sm501_init_dev() fails.

    Fixes: b6d6454fdb66 ("[PATCH] mfd: SM501 core driver")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mfd/sm501.c | 8 +++++++-
    1 file changed, 7 insertions(+), 1 deletion(-)

    diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
    index fbec711c41956..0fe273d2f6190 100644
    --- a/drivers/mfd/sm501.c
    +++ b/drivers/mfd/sm501.c
    @@ -1430,8 +1430,14 @@ static int sm501_plat_probe(struct platform_device *dev)
    goto err_claim;
    }

    - return sm501_init_dev(sm);
    + ret = sm501_init_dev(sm);
    + if (ret)
    + goto err_unmap;
    +
    + return 0;

    + err_unmap:
    + iounmap(sm->regs);
    err_claim:
    release_resource(sm->regs_claim);
    kfree(sm->regs_claim);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 14:59    [W:3.223 / U:1.820 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site