lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/8] ALSA: pcm: use krealloc_array()
    Date
    From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

    Use the helper that checks for overflows internally instead of manually
    calculating the size of the new array.

    Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
    ---
    sound/core/pcm_lib.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
    index d531e1bc2b81..c6f8f9e252e0 100644
    --- a/sound/core/pcm_lib.c
    +++ b/sound/core/pcm_lib.c
    @@ -1129,8 +1129,8 @@ int snd_pcm_hw_rule_add(struct snd_pcm_runtime *runtime, unsigned int cond,
    if (constrs->rules_num >= constrs->rules_all) {
    struct snd_pcm_hw_rule *new;
    unsigned int new_rules = constrs->rules_all + 16;
    - new = krealloc(constrs->rules, new_rules * sizeof(*c),
    - GFP_KERNEL);
    + new = krealloc_array(constrs->rules, new_rules,
    + sizeof(*c), GFP_KERNEL);
    if (!new) {
    va_end(args);
    return -ENOMEM;
    --
    2.29.1
    \
     
     \ /
      Last update: 2020-10-27 13:19    [W:4.186 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site