Messages in this thread | | | Date | Tue, 27 Oct 2020 12:23:03 +0100 | From | Greg KH <> | Subject | Re: [PATCH] staging: rtl8192e, rtl8192u: use correct notation to define pointer |
| |
On Mon, Oct 26, 2020 at 05:14:35PM +0500, Muhammad Usama Anjum wrote: > Use pointer notation instead of using array notation as info_element is > a pointer not array. > > Warnings from sparse: > drivers/staging/rtl8192u/ieee80211/ieee80211.h:1013:51: warning: array of flexible structures > drivers/staging/rtl8192u/ieee80211/ieee80211.h:985:51: warning: array of flexible structures > drivers/staging/rtl8192u/ieee80211/ieee80211.h:963:51: warning: array of flexible structures > drivers/staging/rtl8192u/ieee80211/ieee80211.h:996:51: warning: array of flexible structures > drivers/staging/rtl8192u/ieee80211/ieee80211.h:974:51: warning: array of flexible structures > > drivers/staging/rtl8192e/rtllib.h:832:48: warning: array of flexible structures > drivers/staging/rtl8192e/rtllib.h:851:48: warning: array of flexible structures > drivers/staging/rtl8192e/rtllib.h:805:48: warning: array of flexible structures > drivers/staging/rtl8192e/rtllib.h:843:48: warning: array of flexible structures > drivers/staging/rtl8192e/rtllib.h:821:48: warning: array of flexible structures > > Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com> > --- > drivers/staging/rtl8192e/rtllib.h | 10 +++++----- > drivers/staging/rtl8192u/ieee80211/ieee80211.h | 12 ++++++------ > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h > index b84f00b8d18b..1dab9c3d08a8 100644 > --- a/drivers/staging/rtl8192e/rtllib.h > +++ b/drivers/staging/rtl8192e/rtllib.h > @@ -802,7 +802,7 @@ struct rtllib_authentication { > __le16 transaction; > __le16 status; > /*challenge*/ > - struct rtllib_info_element info_element[]; > + struct rtllib_info_element *info_element; > } __packed;
Are you sure these changes are correct? This isn't just a list of structures after this at the end of the structure?
Please look at commit 5979afa2c4d1 ("staging: Replace zero-length array with flexible-array member") which made most of these flexible arrays.
This is not a pointer, it really is an array, I think sparse is really wrong here, be careful.
thanks,
greg k-h
| |