lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 3/6] ASoC: codecs: lpass-wsa-macro: add dapm widgets and route
From
Date
Thanks Pierre for review on all the patches.

On 26/10/2020 19:58, Pierre-Louis Bossart wrote:
> Run cppcheck on this sort of code:
>
> cppcheck --platform=unix32 --force --max-configs=1024 --inconclusive
> --enable=all --suppress=variableScope sound/soc/codecs/lpass-wsa-macro.c

I normally do sparse checks before sending patches, which did not catch
these.

thanks for the suggestion, I will keep add these checks to my future
patches.

And w.r.t comments, I agree with all the changes and will send v2 with
those fixed!

thanks,
srini

\
 
 \ /
  Last update: 2020-10-27 11:16    [W:0.108 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site