lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] char: ipmi: remove unneeded break
On Mon, Oct 19, 2020 at 12:48:05PM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return

Ok, it's in my next tree.

Thanks,

-corey

>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/char/ipmi/ipmi_devintf.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
> index f7b1c004a12b..3dd1d5abb298 100644
> --- a/drivers/char/ipmi/ipmi_devintf.c
> +++ b/drivers/char/ipmi/ipmi_devintf.c
> @@ -490,7 +490,6 @@ static long ipmi_ioctl(struct file *file,
> }
>
> return ipmi_set_my_address(priv->user, val.channel, val.value);
> - break;
> }
>
> case IPMICTL_GET_MY_CHANNEL_ADDRESS_CMD:
> --
> 2.18.1
>

\
 
 \ /
  Last update: 2020-10-27 22:10    [W:1.244 / U:2.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site