Messages in this thread | | | From | Thomas Langer <> | Subject | RE: [PATCH v7 1/2] dt-bindings: dma: Add bindings for intel LGM SOC | Date | Tue, 27 Oct 2020 19:24:16 +0000 |
| |
Hello Reddy,
I think "Intel" should always be written with a capital "I" (like in the Subject, but except in the binding below)
> + compatible: > + oneOf: > + - const: intel,lgm-cdma > + - const: intel,lgm-dma2tx > + - const: intel,lgm-dma1rx > + - const: intel,lgm-dma1tx > + - const: intel,lgm-dma0tx > + - const: intel,lgm-dma3 > + - const: intel,lgm-toe-dma30 > + - const: intel,lgm-toe-dma31
Bindings are normally not per instance. What if next generation chip gets more DMA modules but has no other changes in the HW block? What is wrong with - const: intel,lgm-cdma - const: intel,lgm-hdma and extra attributes to define the rx/tx restriction (or what do it mean?)? From the driver code I saw that "toe" is also just of type "hdma" and no further differences in code are done.
Best regards, Thomas
| |