lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 037/191] media: platform: fcp: Fix a reference count leak.
    Date
    From: Qiushi Wu <wu000273@umn.edu>

    [ Upstream commit 63e36a381d92a9cded97e90d481ee22566557dd1 ]

    pm_runtime_get_sync() increments the runtime PM usage counter even
    when it returns an error code, causing incorrect ref count if
    pm_runtime_put_noidle() is not called in error handling paths.
    Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails.

    Fixes: 6eaafbdb668b ("[media] v4l: rcar-fcp: Keep the coding style consistent")
    Signed-off-by: Qiushi Wu <wu000273@umn.edu>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/rcar-fcp.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/media/platform/rcar-fcp.c b/drivers/media/platform/rcar-fcp.c
    index 0047d144c9326..19502a1860cf5 100644
    --- a/drivers/media/platform/rcar-fcp.c
    +++ b/drivers/media/platform/rcar-fcp.c
    @@ -106,8 +106,10 @@ int rcar_fcp_enable(struct rcar_fcp_device *fcp)
    return 0;

    ret = pm_runtime_get_sync(fcp->dev);
    - if (ret < 0)
    + if (ret < 0) {
    + pm_runtime_put_noidle(fcp->dev);
    return ret;
    + }

    return 0;
    }
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 19:39    [W:2.100 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site