Messages in this thread | | | From | Patrik Jakobsson <> | Date | Tue, 27 Oct 2020 10:54:27 +0100 | Subject | Re: [PATCH 4/4] drm/gma500: avoid Woverride-init warning |
| |
On Tue, Oct 27, 2020 at 10:33 AM Daniel Vetter <daniel@ffwll.ch> wrote: > > On Mon, Oct 26, 2020 at 08:41:04PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann <arnd@arndb.de> > > > > gcc -Wextra notices that one of the fields in psbfb_roll_ops has two > > initializers: > > > > drivers/gpu/drm/gma500/framebuffer.c:185:20: warning: initialized field overwritten [-Woverride-init] > > > > Open-code this instead, leaving out the extraneous initializers for > > .fb_pan_display. > > > > Fixes: 3da6c2f3b730 ("drm/gma500: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops") > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Scrollback is dead, so I'm not sure it's even worth to keep all this. I'd > just garbage-collect this, maybe als the entire accelerator code and just > leave psbfb_unaccel_ops behind ... > -Daniel
That's been my idea for quite some time. The gtt roll code is also broken in multi display setups.
Arnd, I can take care of this unless you feel an urge to do it yourself.
-Patrik
| |