lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 040/264] crypto: mediatek - Fix wrong return value in mtk_desc_ring_alloc()
    Date
    From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>

    [ Upstream commit 8cbde6c6a6d2b1599ff90f932304aab7e32fce89 ]

    In case of memory allocation failure, a negative error code should
    be returned.

    Fixes: 785e5c616c849 ("crypto: mediatek - Add crypto driver support for some MediaTek chips")
    Cc: Ryder Lee <ryder.lee@mediatek.com>
    Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/mediatek/mtk-platform.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/crypto/mediatek/mtk-platform.c b/drivers/crypto/mediatek/mtk-platform.c
    index ee0404e27a0f2..03b1436f87096 100644
    --- a/drivers/crypto/mediatek/mtk-platform.c
    +++ b/drivers/crypto/mediatek/mtk-platform.c
    @@ -446,7 +446,7 @@ static void mtk_desc_dma_free(struct mtk_cryp *cryp)
    static int mtk_desc_ring_alloc(struct mtk_cryp *cryp)
    {
    struct mtk_ring **ring = cryp->ring;
    - int i, err = ENOMEM;
    + int i;

    for (i = 0; i < MTK_RING_MAX; i++) {
    ring[i] = kzalloc(sizeof(**ring), GFP_KERNEL);
    @@ -480,7 +480,7 @@ static int mtk_desc_ring_alloc(struct mtk_cryp *cryp)
    ring[i]->cmd_base, ring[i]->cmd_dma);
    kfree(ring[i]);
    }
    - return err;
    + return -ENOMEM;
    }

    static int mtk_crypto_probe(struct platform_device *pdev)
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 19:09    [W:4.014 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site