lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/7] platform/chrome: cros_ec_typec: Introduce TYPEC_STATUS
    Hi Prashant,

    Thank you for the patch! Perhaps something to improve:

    [auto build test WARNING on chrome-platform-linux/for-next]
    [also build test WARNING on linus/master v5.10-rc1 next-20201027]
    [cannot apply to linux/master]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use '--base' as documented in
    https://git-scm.com/docs/git-format-patch]

    url: https://github.com/0day-ci/linux/commits/Prashant-Malani/platform-chrome-cros_ec_typec-Register-partner-PD-information/20201022-045552
    base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
    config: x86_64-randconfig-a011-20201027 (attached as .config)
    compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project f2c25c70791de95d2466e09b5b58fc37f6ccd7a4)
    reproduce (this is a W=1 build):
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # install x86_64 cross compiling tool for clang build
    # apt-get install binutils-x86-64-linux-gnu
    # https://github.com/0day-ci/linux/commit/d95c360f8dc525bd78c299a987c1287867f766a2
    git remote add linux-review https://github.com/0day-ci/linux
    git fetch --no-tags linux-review Prashant-Malani/platform-chrome-cros_ec_typec-Register-partner-PD-information/20201022-045552
    git checkout d95c360f8dc525bd78c299a987c1287867f766a2
    # save the attached .config to linux build tree
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64

    If you fix the issue, kindly add following tag as appropriate
    Reported-by: kernel test robot <lkp@intel.com>

    All warnings (new ones prefixed by >>):

    drivers/platform/chrome/cros_ec_typec.c:692:3: warning: format specifies type 'unsigned char' but the argument has type 'unsigned int' [-Wformat]
    typec->pd_ctrl_ver);
    ^~~~~~~~~~~~~~~~~~
    include/linux/dev_printk.h:123:47: note: expanded from macro 'dev_dbg'
    dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
    ~~~ ^~~~~~~~~~~
    >> drivers/platform/chrome/cros_ec_typec.c:698:5: warning: no previous prototype for function 'cros_typec_cmds_supported' [-Wmissing-prototypes]
    int cros_typec_cmds_supported(struct cros_typec_data *typec)
    ^
    drivers/platform/chrome/cros_ec_typec.c:698:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
    int cros_typec_cmds_supported(struct cros_typec_data *typec)
    ^
    static
    2 warnings generated.

    vim +/cros_typec_cmds_supported +698 drivers/platform/chrome/cros_ec_typec.c

    669
    670 static int cros_typec_get_cmd_version(struct cros_typec_data *typec)
    671 {
    672 struct ec_params_get_cmd_versions_v1 req_v1;
    673 struct ec_response_get_cmd_versions resp;
    674 int ret;
    675
    676 /* We're interested in the PD control command version. */
    677 req_v1.cmd = EC_CMD_USB_PD_CONTROL;
    678 ret = cros_typec_ec_command(typec, 1, EC_CMD_GET_CMD_VERSIONS,
    679 &req_v1, sizeof(req_v1), &resp,
    680 sizeof(resp));
    681 if (ret < 0)
    682 return ret;
    683
    684 if (resp.version_mask & EC_VER_MASK(2))
    685 typec->pd_ctrl_ver = 2;
    686 else if (resp.version_mask & EC_VER_MASK(1))
    687 typec->pd_ctrl_ver = 1;
    688 else
    689 typec->pd_ctrl_ver = 0;
    690
    691 dev_dbg(typec->dev, "PD Control has version mask 0x%hhx\n",
    > 692 typec->pd_ctrl_ver);
    693
    694 return 0;
    695 }
    696
    697 /* Check the EC feature flags to see if TYPEC_* commands are supported. */
    > 698 int cros_typec_cmds_supported(struct cros_typec_data *typec)
    699 {
    700 struct ec_response_get_features resp = {};
    701 int ret;
    702
    703 ret = cros_typec_ec_command(typec, 0, EC_CMD_GET_FEATURES, NULL, 0,
    704 &resp, sizeof(resp));
    705 if (ret < 0) {
    706 dev_warn(typec->dev,
    707 "Failed to get features, assuming typec commands unsupported.\n");
    708 return 0;
    709 }
    710
    711 return resp.flags[EC_FEATURE_TYPEC_CMD / 32] & EC_FEATURE_MASK_1(EC_FEATURE_TYPEC_CMD);
    712 }
    713

    ---
    0-DAY CI Kernel Test Service, Intel Corporation
    https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
    [unhandled content-type:application/gzip]
    \
     
     \ /
      Last update: 2020-10-27 19:09    [W:5.987 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site