lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 134/264] RDMA/ucma: Add missing locking around rdma_leave_multicast()
    Date
    From: Jason Gunthorpe <jgg@nvidia.com>

    [ Upstream commit 38e03d092699891c3237b5aee9e8029d4ede0956 ]

    All entry points to the rdma_cm from a ULP must be single threaded,
    even this error unwinds. Add the missing locking.

    Fixes: 7c11910783a1 ("RDMA/ucma: Put a lock around every call to the rdma_cm layer")
    Link: https://lore.kernel.org/r/20200818120526.702120-11-leon@kernel.org
    Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/core/ucma.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c
    index 0c095c8c0ac5b..01052de6bedbf 100644
    --- a/drivers/infiniband/core/ucma.c
    +++ b/drivers/infiniband/core/ucma.c
    @@ -1476,7 +1476,9 @@ static ssize_t ucma_process_join(struct ucma_file *file,
    return 0;

    err3:
    + mutex_lock(&ctx->mutex);
    rdma_leave_multicast(ctx->cm_id, (struct sockaddr *) &mc->addr);
    + mutex_unlock(&ctx->mutex);
    ucma_cleanup_mc_events(mc);
    err2:
    mutex_lock(&mut);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 18:55    [W:2.254 / U:2.872 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site