lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 171/264] clk: rockchip: Initialize hw to error to avoid undefined behavior
    Date
    From: Stephen Boyd <sboyd@kernel.org>

    [ Upstream commit b608f11d49ec671739604cc763248d8e8fadbbeb ]

    We can get down to this return value from ERR_CAST() without
    initializing hw. Set it to -ENOMEM so that we always return something
    sane.

    Fixes the following smatch warning:

    drivers/clk/rockchip/clk-half-divider.c:228 rockchip_clk_register_halfdiv() error: uninitialized symbol 'hw'.
    drivers/clk/rockchip/clk-half-divider.c:228 rockchip_clk_register_halfdiv() warn: passing zero to 'ERR_CAST'

    Cc: Elaine Zhang <zhangqing@rock-chips.com>
    Cc: Heiko Stuebner <heiko@sntech.de>
    Fixes: 956060a52795 ("clk: rockchip: add support for half divider")
    Reviewed-by: Heiko Stuebner <heiko@sntech.de>
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/rockchip/clk-half-divider.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/clk/rockchip/clk-half-divider.c b/drivers/clk/rockchip/clk-half-divider.c
    index b8da6e799423a..6a371d05218da 100644
    --- a/drivers/clk/rockchip/clk-half-divider.c
    +++ b/drivers/clk/rockchip/clk-half-divider.c
    @@ -166,7 +166,7 @@ struct clk *rockchip_clk_register_halfdiv(const char *name,
    unsigned long flags,
    spinlock_t *lock)
    {
    - struct clk *clk;
    + struct clk *clk = ERR_PTR(-ENOMEM);
    struct clk_mux *mux = NULL;
    struct clk_gate *gate = NULL;
    struct clk_divider *div = NULL;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 18:53    [W:3.898 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site