lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v8 03/14] ASoC: sun4i-i2s: Change get_sr() and get_wss() to be more explicit
    On Mon, Oct 26, 2020 at 07:52:28PM +0100, Clément Péron wrote:
    > We are actually using a complex formula to just return a bunch of
    > simple values. Also this formula is wrong for sun4i when calling
    > get_wss() the function return 4 instead of 3.
    >
    > Replace this with a simpler switch case.
    >
    > Also drop the i2s params which is unused and return a simple int as
    > returning an error code could be out of range for an s8 and there is
    > no optim to return a s8 here.
    >
    > Fixes: 619c15f7fac9 ("ASoC: sun4i-i2s: Change SR and WSS computation")
    > Reviewed-by: Chen-Yu Tsai <wens@csie.org>
    > Signed-off-by: Clément Péron <peron.clem@gmail.com>

    Acked-by: Maxime Ripard <mripard@kernel.org>

    Maxime
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2020-10-27 18:51    [W:4.213 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site