lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 206/264] block: ratelimit handle_bad_sector() message
    Date
    From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>

    [ Upstream commit f4ac712e4fe009635344b9af5d890fe25fcc8c0d ]

    syzbot is reporting unkillable task [1], for the caller is failing to
    handle a corrupted filesystem image which attempts to access beyond
    the end of the device. While we need to fix the caller, flooding the
    console with handle_bad_sector() message is unlikely useful.

    [1] https://syzkaller.appspot.com/bug?id=f1f49fb971d7a3e01bd8ab8cff2ff4572ccf3092

    Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    block/blk-core.c | 9 ++++-----
    1 file changed, 4 insertions(+), 5 deletions(-)

    diff --git a/block/blk-core.c b/block/blk-core.c
    index ce3710404544c..445b878e35194 100644
    --- a/block/blk-core.c
    +++ b/block/blk-core.c
    @@ -2127,11 +2127,10 @@ static void handle_bad_sector(struct bio *bio, sector_t maxsector)
    {
    char b[BDEVNAME_SIZE];

    - printk(KERN_INFO "attempt to access beyond end of device\n");
    - printk(KERN_INFO "%s: rw=%d, want=%Lu, limit=%Lu\n",
    - bio_devname(bio, b), bio->bi_opf,
    - (unsigned long long)bio_end_sector(bio),
    - (long long)maxsector);
    + pr_info_ratelimited("attempt to access beyond end of device\n"
    + "%s: rw=%d, want=%llu, limit=%llu\n",
    + bio_devname(bio, b), bio->bi_opf,
    + bio_end_sector(bio), maxsector);
    }

    #ifdef CONFIG_FAIL_MAKE_REQUEST
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 18:51    [W:4.046 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site