lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 099/408] pinctrl: bcm: fix kconfig dependency warning when !GPIOLIB
    Date
    From: Necip Fazil Yildiran <fazilyildiran@gmail.com>

    [ Upstream commit 513034d8b089b9a49dab57845aee70e830fe7334 ]

    When PINCTRL_BCM2835 is enabled and GPIOLIB is disabled, it results in the
    following Kbuild warning:

    WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP
    Depends on [n]: GPIOLIB [=n]
    Selected by [y]:
    - PINCTRL_BCM2835 [=y] && PINCTRL [=y] && OF [=y] && (ARCH_BCM2835 [=n] || ARCH_BRCMSTB [=n] || COMPILE_TEST [=y])

    The reason is that PINCTRL_BCM2835 selects GPIOLIB_IRQCHIP without
    depending on or selecting GPIOLIB while GPIOLIB_IRQCHIP is subordinate to
    GPIOLIB.

    Honor the kconfig menu hierarchy to remove kconfig dependency warnings.

    Fixes: 85ae9e512f43 ("pinctrl: bcm2835: switch to GPIOLIB_IRQCHIP")
    Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
    Link: https://lore.kernel.org/r/20200914144025.371370-1-fazilyildiran@gmail.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pinctrl/bcm/Kconfig | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/pinctrl/bcm/Kconfig b/drivers/pinctrl/bcm/Kconfig
    index dcf7df797af75..0ed14de0134cf 100644
    --- a/drivers/pinctrl/bcm/Kconfig
    +++ b/drivers/pinctrl/bcm/Kconfig
    @@ -23,6 +23,7 @@ config PINCTRL_BCM2835
    select PINMUX
    select PINCONF
    select GENERIC_PINCONF
    + select GPIOLIB
    select GPIOLIB_IRQCHIP
    default ARCH_BCM2835 || ARCH_BRCMSTB
    help
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 18:42    [W:3.145 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site