Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 27 Oct 2020 11:33:17 +0200 | Subject | Re: [PATCH 2/5] iio: adc: xilinx: use devm_krealloc() instead of kfree() + kcalloc() |
| |
On Mon, Oct 26, 2020 at 4:03 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > We now have devm_krealloc() in the kernel Use it indstead of calling > kfree() and kcalloc() separately.
Which is completely lawful when size > previous_size (I mean, the additional patch you sent previously seems not related to this).
> - kfree(xadc->data); > - xadc->data = kcalloc(n, sizeof(*xadc->data), GFP_KERNEL); > + xadc->data = devm_krealloc(indio_dev->dev.parent, xadc->data, > + n * sizeof(*xadc->data),
I think you need to use something from overflow.h instead of explicit multiplication here.
> + GFP_KERNEL | __GFP_ZERO);
-- With Best Regards, Andy Shevchenko
| |