lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/5] iio: adc: xilinx: use devm_krealloc() instead of kfree() + kcalloc()
On Mon, Oct 26, 2020 at 4:03 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> We now have devm_krealloc() in the kernel Use it indstead of calling
> kfree() and kcalloc() separately.

Which is completely lawful when size > previous_size (I mean, the
additional patch you sent previously seems not related to this).

> - kfree(xadc->data);
> - xadc->data = kcalloc(n, sizeof(*xadc->data), GFP_KERNEL);
> + xadc->data = devm_krealloc(indio_dev->dev.parent, xadc->data,
> + n * sizeof(*xadc->data),

I think you need to use something from overflow.h instead of explicit
multiplication here.

> + GFP_KERNEL | __GFP_ZERO);

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-10-27 10:34    [W:0.192 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site