lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 122/408] backlight: sky81452-backlight: Fix refcount imbalance on error
    Date
    From: dinghao.liu@zju.edu.cn <dinghao.liu@zju.edu.cn>

    [ Upstream commit b7a4f80bc316a56d6ec8750e93e66f42431ed960 ]

    When of_property_read_u32_array() returns an error code, a
    pairing refcount decrement is needed to keep np's refcount
    balanced.

    Fixes: f705806c9f355 ("backlight: Add support Skyworks SKY81452 backlight driver")
    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/video/backlight/sky81452-backlight.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c
    index 2355f00f57732..1f6301375fd33 100644
    --- a/drivers/video/backlight/sky81452-backlight.c
    +++ b/drivers/video/backlight/sky81452-backlight.c
    @@ -196,6 +196,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
    num_entry);
    if (ret < 0) {
    dev_err(dev, "led-sources node is invalid.\n");
    + of_node_put(np);
    return ERR_PTR(-EINVAL);
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 18:39    [W:2.208 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site