lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 083/633] EDAC/aspeed: Fix handling of platform_get_irq() error
    Date
    From: Krzysztof Kozlowski <krzk@kernel.org>

    [ Upstream commit afce6996943be265fa39240b67025cfcb1bcdfb1 ]

    platform_get_irq() returns a negative error number on error. In such a
    case, comparison to 0 would pass the check therefore check the return
    value properly, whether it is negative.

    [ bp: Massage commit message. ]

    Fixes: 9b7e6242ee4e ("EDAC, aspeed: Add an Aspeed AST2500 EDAC driver")
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: Borislav Petkov <bp@suse.de>
    Reviewed-by: Stefan Schaeckeler <schaecsn@gmx.net>
    Link: https://lkml.kernel.org/r/20200827070743.26628-1-krzk@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/edac/aspeed_edac.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/edac/aspeed_edac.c b/drivers/edac/aspeed_edac.c
    index b194658b8b5c9..fbec28dc661d7 100644
    --- a/drivers/edac/aspeed_edac.c
    +++ b/drivers/edac/aspeed_edac.c
    @@ -209,8 +209,8 @@ static int config_irq(void *ctx, struct platform_device *pdev)
    /* register interrupt handler */
    irq = platform_get_irq(pdev, 0);
    dev_dbg(&pdev->dev, "got irq %d\n", irq);
    - if (!irq)
    - return -ENODEV;
    + if (irq < 0)
    + return irq;

    rc = devm_request_irq(&pdev->dev, irq, mcr_isr, IRQF_TRIGGER_HIGH,
    DRV_NAME, ctx);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 18:28    [W:4.018 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site