lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 139/633] media: rockchip/rga: Fix a reference count leak.
    Date
    From: Qiushi Wu <wu000273@umn.edu>

    [ Upstream commit 884d638e0853c4b5f01eb6d048fc3b6239012404 ]

    pm_runtime_get_sync() increments the runtime PM usage counter even
    when it returns an error code. Thus call pm_runtime_put_noidle()
    if pm_runtime_get_sync() fails.

    Fixes: f7e7b48e6d79 ("[media] rockchip/rga: v4l2 m2m support")
    Signed-off-by: Qiushi Wu <wu000273@umn.edu>
    Reviewed-by: Heiko Stuebner <heiko@sntech.de>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/rockchip/rga/rga-buf.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/media/platform/rockchip/rga/rga-buf.c b/drivers/media/platform/rockchip/rga/rga-buf.c
    index 36b821ccc1dba..bf9a75b75083b 100644
    --- a/drivers/media/platform/rockchip/rga/rga-buf.c
    +++ b/drivers/media/platform/rockchip/rga/rga-buf.c
    @@ -81,6 +81,7 @@ static int rga_buf_start_streaming(struct vb2_queue *q, unsigned int count)

    ret = pm_runtime_get_sync(rga->dev);
    if (ret < 0) {
    + pm_runtime_put_noidle(rga->dev);
    rga_buf_return_buffers(q, VB2_BUF_STATE_QUEUED);
    return ret;
    }
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 18:27    [W:8.225 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site