lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 157/633] drm/amd/display: Fix wrong return value in dm_update_plane_state()
    Date
    From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>

    [ Upstream commit c35376137e940c3389df2726a92649c01a9844b4 ]

    On an error exit path, a negative error code should be returned
    instead of a positive return value.

    Fixes: 9e869063b0021 ("drm/amd/display: Move iteration out of dm_update_planes")
    Cc: Leo Li <sunpeng.li@amd.com>
    Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    index 7c1cc0ba30a55..78cf9e4fddbdf 100644
    --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    @@ -8178,8 +8178,7 @@ static int dm_update_plane_state(struct dc *dc,
    dm_old_plane_state->dc_state,
    dm_state->context)) {

    - ret = EINVAL;
    - return ret;
    + return -EINVAL;
    }


    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 18:23    [W:4.037 / U:2.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site