Messages in this thread | | | Subject | Re: [PATCH v3 13/28] scsi: hisi_sas_v3_hw: use generic power management | From | John Garry <> | Date | Tue, 27 Oct 2020 17:11:52 +0000 |
| |
On 01/10/2020 13:24, Vaibhav Gupta wrote: > Drivers should do only device-specific jobs. But in general, drivers using > legacy PCI PM framework for .suspend()/.resume() have to manage many PCI > PM-related tasks themselves which can be done by PCI Core itself. This > brings extra load on the driver and it directly calls PCI helper functions > to handle them. > > Switch to the new generic framework by updating function signatures and > define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove > unnecessary calls to the PCI Helper functions along with the legacy > .suspend & .resume bindings. > > Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com> > --- Hi Vaibhav,
Can you please consider rebasing this series? This driver has had many changes in the area of PM for v5.10-rc1
Also please note that my colleague provided a reviewed-by tag for v2, so, if no big significant changes from v2->v3, please add that tag. Obviously, in light of what I say about recent changes, that is not applicable now, but just for future reference.
Thanks, John
| |