lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 239/633] selftests/bpf: Fix endianness issue in sk_assign
    Date
    From: Ilya Leoshkevich <iii@linux.ibm.com>

    [ Upstream commit b6ed6cf4a3acdeab9aed8e0a524850761ec9b152 ]

    server_map's value size is 8, but the test tries to put an int there.
    This sort of works on x86 (unless followed by non-0), but hard fails on
    s390.

    Fix by using __s64 instead of int.

    Fixes: 2d7824ffd25c ("selftests: bpf: Add test for sk_assign")
    Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
    Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
    Acked-by: Andrii Nakryiko <andriin@fb.com>
    Link: https://lore.kernel.org/bpf/20200915113815.3768217-1-iii@linux.ibm.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/bpf/prog_tests/sk_assign.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/bpf/prog_tests/sk_assign.c b/tools/testing/selftests/bpf/prog_tests/sk_assign.c
    index 47fa04adc1471..21c2d265c3e8e 100644
    --- a/tools/testing/selftests/bpf/prog_tests/sk_assign.c
    +++ b/tools/testing/selftests/bpf/prog_tests/sk_assign.c
    @@ -265,7 +265,7 @@ void test_sk_assign(void)
    TEST("ipv6 udp port redir", AF_INET6, SOCK_DGRAM, false),
    TEST("ipv6 udp addr redir", AF_INET6, SOCK_DGRAM, true),
    };
    - int server = -1;
    + __s64 server = -1;
    int server_map;
    int self_net;

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 18:14    [W:4.186 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site