lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 315/757] mt76: mt7615: hold mt76 lock queueing wd in mt7615_queue_key_update
    Date
    From: Lorenzo Bianconi <lorenzo@kernel.org>

    [ Upstream commit cddaaa56375615c256eb6960d3092ddb8a7a9154 ]

    wq queue is always updated holding mt76 spinlock. Grab mt76 lock in
    mt7615_queue_key_update() before putting a new element at the end of the
    queue.

    Fixes: eb99cc95c3b65 ("mt76: mt7615: introduce mt7663u support")
    Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
    Signed-off-by: Felix Fietkau <nbd@nbd.name>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/mediatek/mt76/mt7615/main.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/main.c b/drivers/net/wireless/mediatek/mt76/mt7615/main.c
    index 2d0b1f49fdbcf..bafe2bdeb5eb4 100644
    --- a/drivers/net/wireless/mediatek/mt76/mt7615/main.c
    +++ b/drivers/net/wireless/mediatek/mt76/mt7615/main.c
    @@ -361,7 +361,10 @@ mt7615_queue_key_update(struct mt7615_dev *dev, enum set_key_cmd cmd,
    wd->key.keylen = key->keylen;
    wd->key.cmd = cmd;

    + spin_lock_bh(&dev->mt76.lock);
    list_add_tail(&wd->node, &dev->wd_head);
    + spin_unlock_bh(&dev->mt76.lock);
    +
    queue_work(dev->mt76.wq, &dev->wtbl_work);

    return 0;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 18:09    [W:8.640 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site