lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 437/633] s390/pci: Mark all VFs as not implementing PCI_COMMAND_MEMORY
    Date
    From: Matthew Rosato <mjrosato@linux.ibm.com>

    [ Upstream commit 08b6e22b850c28b6032da1e4d767a33116e23dfb ]

    For s390 we can have VFs that are passed-through without the associated
    PF. Firmware provides an emulation layer to allow these devices to
    operate independently, but is missing emulation of the Memory Space
    Enable bit. For these as well as linked VFs, set no_command_memory
    which specifies these devices do not implement PCI_COMMAND_MEMORY.

    Fixes: abafbc551fdd ("vfio-pci: Invalidate mmaps and block MMIO access on disabled memory")
    Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
    Reviewed-by: Niklas Schnelle <schnelle@linux.ibm.com>
    Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
    Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/s390/pci/pci_bus.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/arch/s390/pci/pci_bus.c b/arch/s390/pci/pci_bus.c
    index 5967f30141563..c93486a9989bc 100644
    --- a/arch/s390/pci/pci_bus.c
    +++ b/arch/s390/pci/pci_bus.c
    @@ -197,9 +197,10 @@ void pcibios_bus_add_device(struct pci_dev *pdev)
    * With pdev->no_vf_scan the common PCI probing code does not
    * perform PF/VF linking.
    */
    - if (zdev->vfn)
    + if (zdev->vfn) {
    zpci_bus_setup_virtfn(zdev->zbus, pdev, zdev->vfn);
    -
    + pdev->no_command_memory = 1;
    + }
    }

    static int zpci_bus_add_device(struct zpci_bus *zbus, struct zpci_dev *zdev)
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 18:02    [W:3.772 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site