lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 552/633] media: atomisp: fix memleak in ia_css_stream_create
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    [ Upstream commit c1bca5b5ced0cbd779d56f60cdbc9f5e6f6449fe ]

    When aspect_ratio_crop_init() fails, curr_stream needs
    to be freed just like what we've done in the following
    error paths. However, current code is returning directly
    and ends up leaking memory.

    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/media/atomisp/pci/sh_css.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/staging/media/atomisp/pci/sh_css.c b/drivers/staging/media/atomisp/pci/sh_css.c
    index 54434c2dbaf90..8473e14370747 100644
    --- a/drivers/staging/media/atomisp/pci/sh_css.c
    +++ b/drivers/staging/media/atomisp/pci/sh_css.c
    @@ -9521,7 +9521,7 @@ ia_css_stream_create(const struct ia_css_stream_config *stream_config,
    if (err)
    {
    IA_CSS_LEAVE_ERR(err);
    - return err;
    + goto ERR;
    }
    #endif
    for (i = 0; i < num_pipes; i++)
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:50    [W:2.224 / U:0.808 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site