lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 363/757] iwlwifi: dbg: remove no filter condition
    Date
    From: Mordechay Goodstein <mordechay.goodstein@intel.com>

    [ Upstream commit bfdb157127dab2a85d4096a68a00ad568c9eb590 ]

    Currently if group-id and command-id values are zero we
    trigger and collect every RX frame,
    this is not the right behavior and zero value
    should be handled like any other filter.

    Signed-off-by: Mordechay Goodstein <mordechay.goodstein@intel.com>
    Fixes: 3ed34fbf9d3b ("iwlwifi: dbg_ini: support FW response/notification region type")
    Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
    Link: https://lore.kernel.org/r/iwlwifi.20200930161256.6a0aae2c0507.I7bd72968279d586af420472707d53106b35efc08@changeid
    Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
    index 9ce7207d9ec5b..e575fc09d3fa4 100644
    --- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
    +++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
    @@ -947,9 +947,8 @@ static bool iwl_dbg_tlv_check_fw_pkt(struct iwl_fw_runtime *fwrt,
    struct iwl_rx_packet *pkt = tp_data->fw_pkt;
    struct iwl_cmd_header *wanted_hdr = (void *)&trig_data;

    - if (pkt && ((wanted_hdr->cmd == 0 && wanted_hdr->group_id == 0) ||
    - (pkt->hdr.cmd == wanted_hdr->cmd &&
    - pkt->hdr.group_id == wanted_hdr->group_id))) {
    + if (pkt && (pkt->hdr.cmd == wanted_hdr->cmd &&
    + pkt->hdr.group_id == wanted_hdr->group_id)) {
    struct iwl_rx_packet *fw_pkt =
    kmemdup(pkt,
    sizeof(*pkt) + iwl_rx_packet_payload_len(pkt),
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:44    [W:2.286 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site