lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 345/757] qtnfmac: fix resource leaks on unsupported iftype error return path
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit 63f6982075d890d7563e2469643f05a37d193f01 ]

    Currently if an unsupported iftype is detected the error return path
    does not free the cmd_skb leading to a resource leak. Fix this by
    free'ing cmd_skb.

    Addresses-Coverity: ("Resource leak")
    Fixes: 805b28c05c8e ("qtnfmac: prepare for AP_VLAN interface type support")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Link: https://lore.kernel.org/r/20200925132224.21638-1-colin.king@canonical.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/quantenna/qtnfmac/commands.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/net/wireless/quantenna/qtnfmac/commands.c b/drivers/net/wireless/quantenna/qtnfmac/commands.c
    index f40d8c3c3d9e5..f3ccbd2b10847 100644
    --- a/drivers/net/wireless/quantenna/qtnfmac/commands.c
    +++ b/drivers/net/wireless/quantenna/qtnfmac/commands.c
    @@ -869,6 +869,7 @@ int qtnf_cmd_send_del_intf(struct qtnf_vif *vif)
    default:
    pr_warn("VIF%u.%u: unsupported iftype %d\n", vif->mac->macid,
    vif->vifid, vif->wdev.iftype);
    + dev_kfree_skb(cmd_skb);
    ret = -EINVAL;
    goto out;
    }
    @@ -1924,6 +1925,7 @@ int qtnf_cmd_send_change_sta(struct qtnf_vif *vif, const u8 *mac,
    break;
    default:
    pr_err("unsupported iftype %d\n", vif->wdev.iftype);
    + dev_kfree_skb(cmd_skb);
    ret = -EINVAL;
    goto out;
    }
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:44    [W:3.452 / U:1.464 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site