lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 619/757] ARM: dts: stm32: lxa-mc1: Fix kernel warning about PHY delays
    Date
    From: Holger Assmann <h.assmann@pengutronix.de>

    [ Upstream commit 42a31ac6698681363363d48335559d212a26a7ca ]

    The KSZ9031 PHY skew timings for rxc/txc, originally set to achieve
    the desired phase shift between clock- and data-signal, now trigger a
    kernel warning when used in rgmii-id mode:

    *-skew-ps values should be used only with phy-mode = "rgmii"

    This is because commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode
    support for the KSZ9031 PHY") now configures own timings when
    phy-mode = "rgmii-id". Device trees wanting to set their own delays
    should use phy-mode "rgmii" instead as the warning prescribes.

    The "standard" timings now used with "rgmii-id" work fine on this
    board, so drop the explicit timings in the device tree and thereby
    silence the warning.

    Fixes: 666b5ca85cd3 ("ARM: dts: stm32: add STM32MP1-based Linux Automation MC-1 board")
    Signed-off-by: Holger Assmann <h.assmann@pengutronix.de>
    Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
    Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
    index 5700e6b700d36..b85025d009437 100644
    --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
    +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
    @@ -121,8 +121,6 @@ ethphy: ethernet-phy@3 { /* KSZ9031RN */
    reset-gpios = <&gpiog 0 GPIO_ACTIVE_LOW>; /* ETH_RST# */
    interrupt-parent = <&gpioa>;
    interrupts = <6 IRQ_TYPE_EDGE_FALLING>; /* ETH_MDINT# */
    - rxc-skew-ps = <1860>;
    - txc-skew-ps = <1860>;
    reset-assert-us = <10000>;
    reset-deassert-us = <300>;
    micrel,force-master;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:42    [W:3.077 / U:0.904 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site