lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 560/757] platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role()
    Date
    From: Azhar Shaikh <azhar.shaikh@intel.com>

    [ Upstream commit 5381b0ed54b6af3c0e8184b43e34154e17904848 ]

    usb_role_switch_set_role() has the second argument as enum for usb_role.
    Currently depending upon the data role i.e. UFP(0) or DFP(1) is sent.
    This eventually translates to USB_ROLE_NONE in case of UFP and
    USB_ROLE_DEVICE in case of DFP. Correct this by sending correct enum
    values as USB_ROLE_DEVICE in case of UFP and USB_ROLE_HOST in case of
    DFP.

    Fixes: 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB mux control")
    Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
    Cc: Prashant Malani <pmalani@chromium.org>
    Reviewed-by: Prashant Malani <pmalani@chromium.org>
    Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
    Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/platform/chrome/cros_ec_typec.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
    index 3fcd27ec9ad8f..10ef1fc75c0e1 100644
    --- a/drivers/platform/chrome/cros_ec_typec.c
    +++ b/drivers/platform/chrome/cros_ec_typec.c
    @@ -591,7 +591,8 @@ static int cros_typec_port_update(struct cros_typec_data *typec, int port_num)
    dev_warn(typec->dev, "Configure muxes failed, err = %d\n", ret);

    return usb_role_switch_set_role(typec->ports[port_num]->role_sw,
    - !!(resp.role & PD_CTRL_RESP_ROLE_DATA));
    + resp.role & PD_CTRL_RESP_ROLE_DATA
    + ? USB_ROLE_HOST : USB_ROLE_DEVICE);
    }

    static int cros_typec_get_cmd_version(struct cros_typec_data *typec)
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:41    [W:2.382 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site