lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 472/757] mtd: rawnand: stm32_fmc2: fix a buffer overflow
    Date
    From: Christophe Kerello <christophe.kerello@st.com>

    [ Upstream commit ab16f54ef3cdb6bbc06a36f636a89e6db8a6cea3 ]

    This patch solves following static checker warning:
    drivers/mtd/nand/raw/stm32_fmc2_nand.c:350 stm32_fmc2_nfc_select_chip()
    error: buffer overflow 'nfc->data_phys_addr' 2 <= 2

    The CS value can only be 0 or 1.

    Signed-off-by: Christophe Kerello <christophe.kerello@st.com>
    Fixes: 2cd457f328c1 ("mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver")
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Link: https://lore.kernel.org/linux-mtd/1595325127-32693-1-git-send-email-christophe.kerello@st.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
    index 7f4546ae91303..5792fb240cb2b 100644
    --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
    +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
    @@ -1762,7 +1762,7 @@ static int stm32_fmc2_nfc_parse_child(struct stm32_fmc2_nfc *nfc,
    return ret;
    }

    - if (cs > FMC2_MAX_CE) {
    + if (cs >= FMC2_MAX_CE) {
    dev_err(nfc->dev, "invalid reg value: %d\n", cs);
    return -EINVAL;
    }
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:40    [W:4.111 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site