lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 606/757] arm64: dts: qcom: pm8916: Remove invalid reg size from wcd_codec
    Date
    From: Stephan Gerhold <stephan@gerhold.net>

    [ Upstream commit c2f0cbb57dbac6da3d38b47b5b96de0fe4e23884 ]

    Tha parent node of "wcd_codec" specifies #address-cells = <1>
    and #size-cells = <0>, which means that each resource should be
    described by one cell for the address and size omitted.

    However, wcd_codec currently lists 0x200 as second cell (probably
    the size of the resource). When parsing this would be treated like
    another memory resource - which is entirely wrong.

    To quote the device tree specification [1]:
    "If the parent node specifies a value of 0 for #size-cells,
    the length field in the value of reg shall be omitted."

    [1]: https://www.devicetree.org/specifications/

    Fixes: 5582fcb3829f ("arm64: dts: apq8016-sbc: add analog audio support with multicodec")
    Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
    Link: https://lore.kernel.org/r/20200915071221.72895-4-stephan@gerhold.net
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm64/boot/dts/qcom/pm8916.dtsi | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi
    index 0bcdf04711079..adf9a5988cdc2 100644
    --- a/arch/arm64/boot/dts/qcom/pm8916.dtsi
    +++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi
    @@ -119,7 +119,7 @@ pm8916_vib: vibrator@c000 {

    wcd_codec: codec@f000 {
    compatible = "qcom,pm8916-wcd-analog-codec";
    - reg = <0xf000 0x200>;
    + reg = <0xf000>;
    reg-names = "pmic-codec-core";
    clocks = <&gcc GCC_CODEC_DIGCODEC_CLK>;
    clock-names = "mclk";
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:40    [W:4.644 / U:0.340 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site