lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 666/757] media: saa7134: avoid a shift overflow
    Date
    From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

    [ Upstream commit 15a36aae1ec1c1f17149b6113b92631791830740 ]

    As reported by smatch:
    drivers/media/pci/saa7134//saa7134-tvaudio.c:686 saa_dsp_writel() warn: should 'reg << 2' be a 64 bit type?

    On a 64-bits Kernel, the shift might be bigger than 32 bits.

    In real, this should never happen, but let's shut up the warning.

    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/pci/saa7134/saa7134-tvaudio.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/media/pci/saa7134/saa7134-tvaudio.c b/drivers/media/pci/saa7134/saa7134-tvaudio.c
    index 79e1afb710758..5cc4ef21f9d37 100644
    --- a/drivers/media/pci/saa7134/saa7134-tvaudio.c
    +++ b/drivers/media/pci/saa7134/saa7134-tvaudio.c
    @@ -683,7 +683,8 @@ int saa_dsp_writel(struct saa7134_dev *dev, int reg, u32 value)
    {
    int err;

    - audio_dbg(2, "dsp write reg 0x%x = 0x%06x\n", reg << 2, value);
    + audio_dbg(2, "dsp write reg 0x%x = 0x%06x\n",
    + (reg << 2) & 0xffffffff, value);
    err = saa_dsp_wait_bit(dev,SAA7135_DSP_RWSTATE_WRR);
    if (err < 0)
    return err;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:34    [W:2.444 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site