lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 722/757] scsi: qedi: Mark all connections for recovery on link down event
    Date
    From: Nilesh Javali <njavali@marvell.com>

    [ Upstream commit 4118879be3755b38171063dfd4a57611d4b20a83 ]

    For short time cable pulls, the in-flight I/O to the firmware is never
    cleaned up, resulting in the behaviour of stale I/O completion causing
    list_del corruption and soft lockup of the system.

    On link down event, mark all the connections for recovery, causing cleanup
    of all the in-flight I/O immediately.

    Link: https://lore.kernel.org/r/20200908095657.26821-7-mrangankar@marvell.com
    Signed-off-by: Nilesh Javali <njavali@marvell.com>
    Signed-off-by: Manish Rangankar <mrangankar@marvell.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/qedi/qedi_main.c | 10 ++++++++++
    1 file changed, 10 insertions(+)

    diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
    index 6f038ae5efcaf..dfe24b505b402 100644
    --- a/drivers/scsi/qedi/qedi_main.c
    +++ b/drivers/scsi/qedi/qedi_main.c
    @@ -1127,6 +1127,15 @@ static void qedi_schedule_recovery_handler(void *dev)
    schedule_delayed_work(&qedi->recovery_work, 0);
    }

    +static void qedi_set_conn_recovery(struct iscsi_cls_session *cls_session)
    +{
    + struct iscsi_session *session = cls_session->dd_data;
    + struct iscsi_conn *conn = session->leadconn;
    + struct qedi_conn *qedi_conn = conn->dd_data;
    +
    + qedi_start_conn_recovery(qedi_conn->qedi, qedi_conn);
    +}
    +
    static void qedi_link_update(void *dev, struct qed_link_output *link)
    {
    struct qedi_ctx *qedi = (struct qedi_ctx *)dev;
    @@ -1138,6 +1147,7 @@ static void qedi_link_update(void *dev, struct qed_link_output *link)
    QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_INFO,
    "Link Down event.\n");
    atomic_set(&qedi->link_state, QEDI_LINK_DOWN);
    + iscsi_host_for_each_session(qedi->shost, qedi_set_conn_recovery);
    }
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:25    [W:4.740 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site