lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 436/757] RDMA/qedr: Fix use of uninitialized field
    Date
    From: Michal Kalderon <michal.kalderon@marvell.com>

    [ Upstream commit a379ad54e55a12618cae7f6333fd1b3071de9606 ]

    dev->attr.page_size_caps was used uninitialized when setting device
    attributes

    Fixes: ec72fce401c6 ("qedr: Add support for RoCE HW init")
    Link: https://lore.kernel.org/r/20200902165741.8355-4-michal.kalderon@marvell.com
    Signed-off-by: Michal Kalderon <michal.kalderon@marvell.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/hw/qedr/main.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c
    index d85f992bac299..8e1365951fb6a 100644
    --- a/drivers/infiniband/hw/qedr/main.c
    +++ b/drivers/infiniband/hw/qedr/main.c
    @@ -602,7 +602,7 @@ static int qedr_set_device_attr(struct qedr_dev *dev)
    qed_attr = dev->ops->rdma_query_device(dev->rdma_ctx);

    /* Part 2 - check capabilities */
    - page_size = ~dev->attr.page_size_caps + 1;
    + page_size = ~qed_attr->page_size_caps + 1;
    if (page_size > PAGE_SIZE) {
    DP_ERR(dev,
    "Kernel PAGE_SIZE is %ld which is smaller than minimum page size (%d) required by qedr\n",
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:25    [W:4.971 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site