lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 485/757] powerpc/perf/hv-gpci: Fix starting index value
    Date
    From: Kajol Jain <kjain@linux.ibm.com>

    [ Upstream commit 0f9866f7e85765bbda86666df56c92f377c3bc10 ]

    Commit 9e9f60108423f ("powerpc/perf/{hv-gpci, hv-common}: generate
    requests with counters annotated") adds a framework for defining
    gpci counters.
    In this patch, they adds starting_index value as '0xffffffffffffffff'.
    which is wrong as starting_index is of size 32 bits.

    Because of this, incase we try to run hv-gpci event we get error.

    In power9 machine:

    command#: perf stat -e hv_gpci/system_tlbie_count_and_time_tlbie_instructions_issued/
    -C 0 -I 1000
    event syntax error: '..bie_count_and_time_tlbie_instructions_issued/'
    \___ value too big for format, maximum is 4294967295

    This patch fix this issue and changes starting_index value to '0xffffffff'

    After this patch:

    command#: perf stat -e hv_gpci/system_tlbie_count_and_time_tlbie_instructions_issued/ -C 0 -I 1000
    1.000085786 1,024 hv_gpci/system_tlbie_count_and_time_tlbie_instructions_issued/
    2.000287818 1,024 hv_gpci/system_tlbie_count_and_time_tlbie_instructions_issued/
    2.439113909 17,408 hv_gpci/system_tlbie_count_and_time_tlbie_instructions_issued/

    Fixes: 9e9f60108423 ("powerpc/perf/{hv-gpci, hv-common}: generate requests with counters annotated")
    Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20201003074943.338618-1-kjain@linux.ibm.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/perf/hv-gpci-requests.h | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/arch/powerpc/perf/hv-gpci-requests.h b/arch/powerpc/perf/hv-gpci-requests.h
    index e608f9db12ddc..8965b4463d433 100644
    --- a/arch/powerpc/perf/hv-gpci-requests.h
    +++ b/arch/powerpc/perf/hv-gpci-requests.h
    @@ -95,7 +95,7 @@ REQUEST(__field(0, 8, partition_id)

    #define REQUEST_NAME system_performance_capabilities
    #define REQUEST_NUM 0x40
    -#define REQUEST_IDX_KIND "starting_index=0xffffffffffffffff"
    +#define REQUEST_IDX_KIND "starting_index=0xffffffff"
    #include I(REQUEST_BEGIN)
    REQUEST(__field(0, 1, perf_collect_privileged)
    __field(0x1, 1, capability_mask)
    @@ -223,7 +223,7 @@ REQUEST(__field(0, 2, partition_id)

    #define REQUEST_NAME system_hypervisor_times
    #define REQUEST_NUM 0xF0
    -#define REQUEST_IDX_KIND "starting_index=0xffffffffffffffff"
    +#define REQUEST_IDX_KIND "starting_index=0xffffffff"
    #include I(REQUEST_BEGIN)
    REQUEST(__count(0, 8, time_spent_to_dispatch_virtual_processors)
    __count(0x8, 8, time_spent_processing_virtual_processor_timers)
    @@ -234,7 +234,7 @@ REQUEST(__count(0, 8, time_spent_to_dispatch_virtual_processors)

    #define REQUEST_NAME system_tlbie_count_and_time
    #define REQUEST_NUM 0xF4
    -#define REQUEST_IDX_KIND "starting_index=0xffffffffffffffff"
    +#define REQUEST_IDX_KIND "starting_index=0xffffffff"
    #include I(REQUEST_BEGIN)
    REQUEST(__count(0, 8, tlbie_instructions_issued)
    /*
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:21    [W:4.099 / U:0.584 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site