lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 208/757] scsi: csiostor: Fix wrong return value in csio_hw_prep_fw()
    Date
    From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>

    [ Upstream commit 44f4daf8678ae5f08c93bbe70792f90cd88e4649 ]

    On an error exit path, a negative error code should be returned instead of
    a positive return value.

    Link: https://lore.kernel.org/r/20200802111531.5065-1-tianjia.zhang@linux.alibaba.com
    Fixes: f40e74ffa3de ("csiostor:firmware upgrade fix")
    Cc: Praveen Madhavan <praveenm@chelsio.com>
    Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/csiostor/csio_hw.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/csiostor/csio_hw.c b/drivers/scsi/csiostor/csio_hw.c
    index 7fa20609d5e7f..e43c5413ce29b 100644
    --- a/drivers/scsi/csiostor/csio_hw.c
    +++ b/drivers/scsi/csiostor/csio_hw.c
    @@ -2384,7 +2384,7 @@ static int csio_hw_prep_fw(struct csio_hw *hw, struct fw_info *fw_info,
    FW_HDR_FW_VER_MICRO_G(c), FW_HDR_FW_VER_BUILD_G(c),
    FW_HDR_FW_VER_MAJOR_G(k), FW_HDR_FW_VER_MINOR_G(k),
    FW_HDR_FW_VER_MICRO_G(k), FW_HDR_FW_VER_BUILD_G(k));
    - ret = EINVAL;
    + ret = -EINVAL;
    goto bye;
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:11    [W:4.060 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site