lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 332/757] tty: hvc: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit 75fc65079d8253e1c25a5f8348111a85d71e0f01 ]

    aarch64-linux-gnu-ld: drivers/tty/hvc/hvc_dcc.o: in function `dcc_early_write':
    hvc_dcc.c:(.text+0x164): undefined reference to `uart_console_write'

    The driver uses the uart_console_write(), but SERIAL_CORE_CONSOLE is not
    selected, so uart_console_write is not defined, then we get the error.
    Fix this by selecting SERIAL_CORE_CONSOLE.

    Fixes: d1a1af2cdf19 ("hvc: dcc: Add earlycon support")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Link: https://lore.kernel.org/r/20200919063535.2809707-1-yangyingliang@huawei.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/tty/hvc/Kconfig | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/tty/hvc/Kconfig b/drivers/tty/hvc/Kconfig
    index d1b27b0522a3c..8d60e0ff67b4d 100644
    --- a/drivers/tty/hvc/Kconfig
    +++ b/drivers/tty/hvc/Kconfig
    @@ -81,6 +81,7 @@ config HVC_DCC
    bool "ARM JTAG DCC console"
    depends on ARM || ARM64
    select HVC_DRIVER
    + select SERIAL_CORE_CONSOLE
    help
    This console uses the JTAG DCC on ARM to create a console under the HVC
    driver. This console is used through a JTAG only on ARM. If you don't have
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:11    [W:4.217 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site