lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 157/757] hwmon: (w83627ehf) Fix a resource leak in probe
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 18360b33a071e5883250fd1e04bfdeff8c3887a3 ]

    Smatch has a new check for resource leaks which found a bug in probe:

    drivers/hwmon/w83627ehf.c:2417 w83627ehf_probe()
    warn: 'res->start' not released on lines: 2412.

    We need to clean up if devm_hwmon_device_register_with_info() fails.

    Fixes: 266cd5835947 ("hwmon: (w83627ehf) convert to with_info interface")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Dr. David Alan Gilbert <linux@treblig.org>
    Link: https://lore.kernel.org/r/20200921125212.GA1128194@mwanda
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hwmon/w83627ehf.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
    index 5a5120121e507..3964ceab2817c 100644
    --- a/drivers/hwmon/w83627ehf.c
    +++ b/drivers/hwmon/w83627ehf.c
    @@ -1951,8 +1951,12 @@ static int w83627ehf_probe(struct platform_device *pdev)
    data,
    &w83627ehf_chip_info,
    w83627ehf_groups);
    + if (IS_ERR(hwmon_dev)) {
    + err = PTR_ERR(hwmon_dev);
    + goto exit_release;
    + }

    - return PTR_ERR_OR_ZERO(hwmon_dev);
    + return 0;

    exit_release:
    release_region(res->start, IOREGION_LENGTH);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:11    [W:4.050 / U:0.292 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site