Messages in this thread | | | Subject | Re: [PATCH 1/4] drm/tilcdc: avoid 'make W=2' build failure | From | Jyri Sarha <> | Date | Tue, 27 Oct 2020 17:31:34 +0200 |
| |
On 26/10/2020 21:41, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The -Wmissing-field-initializer warning when building with W=2 > turns into an error because tilcdc is built with -Werror: > > drm/tilcdc/tilcdc_drv.c:431:33: error: missing field 'data' initializer [-Werror,-Wmissing-field-initializers] { "regs", tilcdc_regs_show, 0 }, > drm/tilcdc/tilcdc_drv.c:432:33: error: missing field 'data' initializer [-Werror,-Wmissing-field-initializers] { "mm", tilcdc_mm_show, 0 }, > > Add the missing field initializers to address the warning. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Jyri Sarha <jsarha@ti.com>
Please let me know if you want me to merge this.
Best regards, Jyri
> --- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > index 4f5fc3e87383..754a66051a21 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > @@ -428,8 +428,8 @@ static int tilcdc_mm_show(struct seq_file *m, void *arg) > } > > static struct drm_info_list tilcdc_debugfs_list[] = { > - { "regs", tilcdc_regs_show, 0 }, > - { "mm", tilcdc_mm_show, 0 }, > + { "regs", tilcdc_regs_show, 0, NULL }, > + { "mm", tilcdc_mm_show, 0, NULL }, > }; > > static void tilcdc_debugfs_init(struct drm_minor *minor) >
-- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
| |