lkml.org 
[lkml]   [2020]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 402/757] powerpc/icp-hv: Fix missing of_node_put() in success path
    Date
    From: Nicholas Mc Guire <hofrat@osadl.org>

    [ Upstream commit d3e669f31ec35856f5e85df9224ede5bdbf1bc7b ]

    Both of_find_compatible_node() and of_find_node_by_type() will return
    a refcounted node on success - thus for the success path the node must
    be explicitly released with a of_node_put().

    Fixes: 0b05ac6e2480 ("powerpc/xics: Rewrite XICS driver")
    Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/1530691407-3991-1-git-send-email-hofrat@osadl.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/sysdev/xics/icp-hv.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/powerpc/sysdev/xics/icp-hv.c b/arch/powerpc/sysdev/xics/icp-hv.c
    index ad8117148ea3b..21b9d1bf39ff6 100644
    --- a/arch/powerpc/sysdev/xics/icp-hv.c
    +++ b/arch/powerpc/sysdev/xics/icp-hv.c
    @@ -174,6 +174,7 @@ int icp_hv_init(void)

    icp_ops = &icp_hv_ops;

    + of_node_put(np);
    return 0;
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-27 17:10    [W:4.285 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site